Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer and Header font phpdoc fixes + constructor $pdfa phpdoc fix + setHeaderData lw param fix #402

Merged
merged 7 commits into from
Dec 28, 2021

Conversation

williamdes
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #402 (feae9bf) into main (172540d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files         127      127           
  Lines       23024    23024           
=======================================
  Hits        16792    16792           
  Misses       6232     6232           
Flag Coverage Δ
php-5.3-ubuntu-latest 72.40% <ø> (-0.01%) ⬇️
php-5.4-ubuntu-latest 72.40% <ø> (-0.01%) ⬇️
php-5.5-ubuntu-latest 72.40% <ø> (-0.01%) ⬇️
php-5.6-ubuntu-latest 45.12% <ø> (-0.01%) ⬇️
php-7.1-ubuntu-latest 45.67% <ø> (ø)
php-7.2-ubuntu-latest 45.62% <ø> (ø)
php-7.3-ubuntu-latest 45.61% <ø> (-0.01%) ⬇️
php-7.4-ubuntu-latest 45.61% <ø> (ø)
php-8.0-ubuntu-latest 65.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tcpdf.php 70.87% <ø> (ø)
examples/example_047.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172540d...feae9bf. Read the comment docs.

@williamdes williamdes changed the title Footer and Header font signature fixes Footer and Header font phpdoc fixes + constructor $pdfa phpdoc fix Jul 20, 2021
williamdes added a commit to phpmyadmin/phpmyadmin that referenced this pull request Jul 20, 2021
See: tecnickcom/TCPDF#402

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Contributor Author

I did some more findings and added bool on two function phpdocs

@williamdes williamdes changed the title Footer and Header font phpdoc fixes + constructor $pdfa phpdoc fix Footer and Header font phpdoc fixes + constructor $pdfa phpdoc fix + setHeaderData lw param fix Aug 3, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2021

CLA assistant check
All committers have signed the CLA.

@nicolaasuni nicolaasuni merged commit a9b327d into tecnickcom:main Dec 28, 2021
@williamdes williamdes deleted the signature-fixes branch December 28, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants