Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Add a 'working-directory' option #157

Closed
drummerjolev opened this issue Jul 1, 2021 · 3 comments
Closed

Add a 'working-directory' option #157

drummerjolev opened this issue Jul 1, 2021 · 3 comments
Assignees
Labels
Type: Feature New feature or request
Projects

Comments

@drummerjolev
Copy link

Please describe your suggestion: 提案の概要

I have a monorepo where subdirectories are NPM packages, each with their own package.json. I want to run ESLint from each subdirectory only on modified files in a PR, and want to use this action to provide the list of files that were changed.

However, the action runs in the root by default, where there is package.json. So the list always looks like: [subdirectory/**/file, etc.]. Whereas I would like to receive it as [**/file, etc.]

Describe the solution you'd like: 考えうる解決方法

A working-directory option, similarly to run e.g.:
Screenshot 2021-07-01 at 17 03 53

Then, git diff could run with the --relative flag.

Describe alternatives you've considered: 考えうる代替案

Using bash to process the file names returned by the action – doable but very cumbersome.

Additional context: 補足

n/a

@welcome
Copy link

welcome bot commented Jul 1, 2021

🙌 Thanks for opening your first issue here! Be sure to follow the issue template!

@github-actions github-actions bot added this to To do in Backlog Jul 1, 2021
@technote-space technote-space moved this from To do to In progress in Backlog Jul 2, 2021
@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Jul 2, 2021
@technote-space technote-space added the Type: Feature New feature or request label Jul 2, 2021
technote-space added a commit that referenced this issue Jul 2, 2021
@technote-space
Copy link
Owner

I have added the RELATIVE option, so use that.

https://github.com/technote-space/get-diff-action#specify-a-relative-path

Backlog automation moved this from In progress to Done Jul 2, 2021
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Jul 2, 2021
@drummerjolev
Copy link
Author

Amazing work! Thanks a lot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New feature or request
Projects
Backlog
  
Done
Development

No branches or pull requests

2 participants