Skip to content

Fix wrong output in README.md #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2020
Merged

Fix wrong output in README.md #423

merged 2 commits into from
Sep 22, 2020
+0 −3

Conversation

jechol
Copy link
Contributor

@jechol jechol commented Sep 17, 2020

url doesn't include query parameters.

@jechol
Update README.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8b26c48
@teamon
Copy link
Member

teamon commented Sep 17, 2020

Nice catch!

I think we can remove this example, it doesn't bring much value.

@jechol jechol closed this Sep 22, 2020
@jechol jechol reopened this Sep 22, 2020
@jechol
Update README.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f1eab17 
Remove unuseful example
@jechol
Copy link
Contributor Author

jechol commented Sep 22, 2020

@teamon Removed the line instead of fixing as you said.

@teamon teamon merged commit d658bce into elixir-tesla:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jechol @teamon