Rack-test driver adds additional carriage return to CR+LF in textareas #2547
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HTML spec line breaks in forms should be represented as CR+LF (
\r\n
). The rack-test driver correctly converts this when a textarea contains\n
. However if the textarea already had\r\n
the driver adds another\r
after the form is submitted resulting in an additional carriage return:\r\r\n
.This change does not add an additional carriage return when there already is one.