Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled js modules are vulnerable #2500

Closed
arothian opened this issue Oct 20, 2021 · 3 comments
Closed

Bundled js modules are vulnerable #2500

arothian opened this issue Oct 20, 2021 · 3 comments

Comments

@arothian
Copy link

Hello 馃憢馃徎

There are included JS dependencies in this gem that have published CVEs. The items in question are included here.

In particular, the jquery-ui bundled is v1.11.4, which is vulnerable to CVE-2016-7103

The impact of this is that consumers of capybara might see failures in static analysis of packages. These dependencies should be updated or excluded from the gemspec.

Meta

Capybara Version: latest

@twalpole
Copy link
Member

The packages are included for third party driver authors to be able to be run Capybaras tests against their drivers, and will not be excluded from the gemspec. These files are not used by end users of Capybara, and are easily excludable from any static analysis tool. We will look at updating the dependencies but I don't consider this a valid security concern.

@Jackiesan
Copy link

Hello I had the same exact question. Thanks for creating a pull request to update the dependency. @twalpole Is there anything blocking pull request #2503 from being merged?

@twalpole
Copy link
Member

@Jackiesan Time to figure out why the visibility behavior changes when using the new versions. Assumption is that it shouldn't have any effect since jQuery isn't used in the visibility calculations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants