Improve Capybara::Node::Element API doc
#2201
Merged
+86
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
commented
May 24, 2019
ybiquitous
commented
May 24, 2019
ybiquitous
commented
May 24, 2019
ybiquitous
commented
May 24, 2019
ybiquitous
commented
May 24, 2019
Pull Request Test Coverage Report for Build 6166
💛 - Coveralls |
twalpole
reviewed
May 24, 2019
twalpole
reviewed
May 24, 2019
|
I pushed 79a9c0c to fix all reviews. |
|
LGTM - please rebase and then I'll merge - Note: if you end your PR description with "[ci skip]" when only changing docs it will prevent firing off the travis test runs. |
Summary: - Change plain-text references to links. - Add missing descriptions. - Fix the broken list in `#send_keys` doc. The current doc at v3.20.2: <https://www.rubydoc.info/gems/capybara/3.20.2/Capybara/Node/Element> This change is extracted from teamcapybara#2190. [ci skip]
ybiquitous
force-pushed
the
improve-element-api-doc
branch
from
79a9c0c to
be34c81
Compare
|
Thanks a lot! I rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#send_keysdoc.The current doc at v3.20.2: https://www.rubydoc.info/gems/capybara/3.20.2/Capybara/Node/Element
This change is extracted from #2190.