Remove uses of Timeout.timeout from Server
#2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I expect this to be equivalent since it rases the same error and has the same pattern of sleeps.
I expect this to be equivalent since it rases the same error and has the same pattern of sleeps. I don't know of any problems caused by using timeout here, instead I've converted this for consistency and so that that there are no longer any uses of `Timeout.timeout` within the codebase.
|
LGTM - thanks |
|
@twalpole thanks for merging. |
twalpole
pushed a commit
that referenced
this pull request
Apr 19, 2018
* Don't use Timeout.timeout in Server#wait_for_pending_requests I expect this to be equivalent since it rases the same error and has the same pattern of sleeps. * Don't use Timeout.timeout in Server#boot I expect this to be equivalent since it rases the same error and has the same pattern of sleeps. I don't know of any problems caused by using timeout here, instead I've converted this for consistency and so that that there are no longer any uses of `Timeout.timeout` within the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently had some intermittent failures in our test suite with the error 'Requests did not finish in 60 seconds'. After investigating we found that the block passed to
Timeout.timeoutthat was hanging. We were unable to find out why, but re-writing the code to use awhileloop rather thanTimeout.timeoutstopped the issue from occurring. You can read more on the mailing list.Even if the intermittent problem is only effecting us, I think this change could be justified as an improvement. Timeout is generally considered dangerous to use since the exception may interrupt the code at any point. The
Serverclass is the only part of capybara that usesTimeout.timeout, elsewhere uses a loop similar to the pattern I've followed here.While we were only seeing problems from the call to
Timeoutinwait_for_pending_requests, I've changed the other use ofTimeoutinServer#bootsince it was the only other use ofTimeoutin the codebase.Since this timeout pattern exists in lots of places in capybara I looked at extracting it into
Capybara::Helpersto make it easier to follow, however because of the diversity of the way that the timeouts work (different timings, predicates, sleep intervals and errors raised) I found it hard to bring together if without changing the existing behaviour or passing in lots of arguments & multiple blocks so decided not to.