Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexo-fs out of date cause fail to install on node v13 #21

Open
wafer-li opened this issue Dec 7, 2019 · 3 comments
Open

hexo-fs out of date cause fail to install on node v13 #21

wafer-li opened this issue Dec 7, 2019 · 3 comments

Comments

@wafer-li
Copy link

wafer-li commented Dec 7, 2019

Actually the fsevents@v1 cause this problem, and the out-of-date hexo-fs depends on that cause install fail on node v13.

This might related to another plugin nunjucks which indirectly depends on fsevents@v1 which introduced in hexo@v4

@tea3
Copy link
Owner

tea3 commented Dec 9, 2019

@wafer-li
Thank you for report this issue. Do this issue relate Upgrade to fsevent v2 - Node 13 support ?

@wafer-li
Copy link
Author

wafer-li commented Dec 9, 2019

@tea3
I did some investigations about this.

There is a issue on fsevents repo.
It might be the new node@v13 needs a new fsevent@v1 binary.
And there are no such new binary of fsevents@v1.
Therefore they recommended to upgrade to fsevents@v2 which get rid of AWS binary.

But not only hexo-fs depends on fsevents@v1 but also the famous chokidar < v3.

And hexo@v4 depends on nunjucks which depends on babel which depends on chokidar < v3 which depends on the old fsevents@v1.

Graph might seems like this:

hexo@v4 -> nunjucks -> babel -> chokidar < v3 -> fsevents@v1

And the babel team claim a major release to fix this issue but they need to wait until the eol of node@v10 which is 2019-12-31.

Therefore, upgrade hexo-fs could fix this package's dependency issue.
But only fixing in this package will not work since the hexo dependency issue will not fixed until 2020-01-01

@wafer-li
Copy link
Author

Since now the hexo-5.0.0 is released, the chokidar < v3 dependencies is no longer exists.

We should now upgrade the hexo-fs to get rid of the old fsevents@v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants