Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --fix flag #70

Open
bentruyman opened this issue Jan 25, 2018 · 4 comments
Open

Add --fix flag #70

bentruyman opened this issue Jan 25, 2018 · 4 comments
Labels
enhancement 👑 New feature or request
Milestone

Comments

@bentruyman
Copy link

It would be nice if there were a --fix flag, similar to tools like eslint, which handles fixable errors in a project's package.json. From what I can see, the rules that could be fixable include: prefer-property-order and the prefer-alphabetical-* rules.

prefer-property-order is particularly annoying as it typically involves running pjl-cli over and over again until the desired order is met.

Could this be achieved simply by adding a new fix property to each rule that is fixable and invoke it if the --fix flag is passed in?

@tclindner tclindner added the enhancement 👑 New feature or request label Jan 27, 2018
@tclindner
Copy link
Owner

Hey @bentruyman - thank you for using the project! This is a great suggestion! I like your recommendation to start with those two rules.

@tclindner tclindner added this to To do in v4 via automation Jun 16, 2019
@tclindner tclindner added this to the v4.0.0 milestone Jun 16, 2019
@piranna
Copy link

piranna commented Jan 12, 2020

Any update on that? Seems just only the CLI support the --fix flag but without any actual code behind... :-/

@tclindner
Copy link
Owner

Hey @piranna - you are correct. v4 added the fix flag to the cli interface, but nothing has been implemented behind it. v3 and v4 went through some pretty major structural changes and this feature unfortunately got pushed to the side. I’ve been pretty busy recently. I’ll try to get back to focusing in the next couple of weeks.

Thank you for you patiences.

@piranna
Copy link

piranna commented Jan 15, 2020

You are welcome :-) Please keep us updated when this works again :-D

@tclindner tclindner removed this from To do in v4 Jan 30, 2020
@tclindner tclindner modified the milestones: v4.0.0, v5.0.0 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👑 New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants