Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require name scope #200

Open
piranna opened this issue Jan 26, 2020 · 7 comments
Open

Require name scope #200

piranna opened this issue Jan 26, 2020 · 7 comments

Comments

@piranna
Copy link

piranna commented Jan 26, 2020

Add new rule to require name to have defined a scope. Ideally It should be a three state field (always, never or don't café).

@piranna
Copy link
Author

piranna commented Jan 26, 2020

Maybe valid-name-scope would do the job with a regexp, in that case an example is needed un the docs.

@tclindner
Copy link
Owner

Thank you, @piranna! I take a look at this tomorrow and get back to you.

@piranna
Copy link
Author

piranna commented Jan 29, 2020

Thank you! :-)

@tclindner
Copy link
Owner

@piranna do you think valid-values-name-scope will meet your needs? error covers always. off covers don't care. never is a gap.

btw - I've got time this weekend to get caught up on some tickets 🤓

@piranna
Copy link
Author

piranna commented Jan 30, 2020

@piranna do you think valid-values-name-scope will meet your needs? error covers always. off covers don't care. never is a gap.

Didn't test it, but as I've told you in #200 (comment), reviewing the code maybe it could work by defining a regular expression instead of a full scope, just only it would need to be tested :-)

By the way, why dows it requires the @ to be defined in the name scope? Is it for generity in case there's another registry don't use that pattern for scopes?

@tclindner
Copy link
Owner

@piranna - yes, re: @. Do you have any concerns with that approach?

I'm going to focus on adding plugin support next. Do you have an immediate use case for never right now? If so, I can focus on this first.

@piranna
Copy link
Author

piranna commented Feb 18, 2020

@piranna - yes, re: @. Do you have any concerns with that approach?

Not at all, just only would be nice to have that in the documentation :-)

Do you have an immediate use case for never right now?

Not at all :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants