Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: prefer-no-devDependencies #133

Merged
merged 2 commits into from Oct 6, 2019
Merged

Add: prefer-no-devDependencies #133

merged 2 commits into from Oct 6, 2019

Conversation

simison
Copy link
Contributor

@simison simison commented Oct 4, 2019

Description of change

  • Adds prefer-no-devDependencies rule
  • Create a new "Disallowed node" category and move prefer-no-engineStrict rule there

Happy to add also prefer-no-dependencies, prefer-no-optionalDependencies and prefer-no-peerDependencies if you see this is useful.

Resolves #132 (see the issue for use case)

Checklist

  • Unit tests have been added
  • Specific notes for documentation, if applicable

@simison
Copy link
Contributor Author

simison commented Oct 4, 2019

BTW alternative API for this could be prefer-no rule with a list of not allowed rules.

@tclindner tclindner added the enhancement 👑 New feature or request label Oct 6, 2019
@tclindner tclindner added this to In progress in v4 via automation Oct 6, 2019
@tclindner tclindner added this to the v4.0.0 milestone Oct 6, 2019
Copy link
Owner

@tclindner tclindner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @simison - Thank you so much for adding this 🙌

@@ -197,8 +197,9 @@ Add the following to your `.npmpackagejsonlintrc.json` file.
* [prefer-property-order](rules/package-json-properties/prefer-property-order.md)


## Deprecated node rules
## Disallowed node rules
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,38 @@
---
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding docs 🎉

@tclindner
Copy link
Owner

I would love to add prefer-no-dependencies, prefer-no-optionalDependencies, and prefer-no-peerDependencies if you have time. Thank you so much for offering 🥇

@tclindner tclindner merged commit eaac08b into tclindner:master Oct 6, 2019
v4 automation moved this from In progress to Done Oct 6, 2019
@simison simison deleted the add/prefer-no-devDependencies branch April 27, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👑 New feature or request
Projects
No open projects
v4
  
Done
Development

Successfully merging this pull request may close these issues.

Enhancement: prefer-no-dependencies rules
2 participants