Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for v flag #4077

Open
sosukesuzuki opened this issue May 12, 2024 · 0 comments
Open

Add more tests for v flag #4077

sosukesuzuki opened this issue May 12, 2024 · 0 comments

Comments

@sosukesuzuki
Copy link
Contributor

sosukesuzuki commented May 12, 2024

The behavior of the following built-ins and abstract operations depends on the v flag.

  • RegExp.prototype.@@match
  • RegExp.prototype.@@matchAll
  • RegExp.prototype.@@replace
  • RegExp.prototype.@@search
  • RegExpBuiltinExec

The unicode mode is enabled by the step such as

If flags contains "u" or flags contains "v", let fullUnicode be true.

There is a test in test262 for using these built-ins with the u flag(1), but not for the v flag.

So we had a bug2 in WebKit where RegExp.prototype.@@matchAll did not support the v flag (already fixed).

We should add tests for this in test262.

Footnotes

  1. https://github.com/tc39/test262/blob/main/test/built-ins/RegExp/prototype/Symbol.match/u-advance-after-empty.js

  2. https://bugs.webkit.org/show_bug.cgi?id=272274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant