Add tests for Object.groupBy and Map.groupBy with string items
#4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Apr 1, 2024
ljharb
reviewed
Apr 1, 2024
ljharb
reviewed
Apr 1, 2024
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
reviewed
Apr 1, 2024
ljharb
approved these changes
Apr 1, 2024
ptomato
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Not much to add to what Jordan said.
For me this is also fine to merge as is, but as long as we're on the topic of grouping strings with weird edge cases: if you felt like doing extra work, I think it might help to have coverage for ASCII strings (to help debuggability in case an implementation gets single characters right but surrogate pairs wrong) and grapheme clusters (like 👨👦 being split into 👨, ZWJ, and 👦.)
Thanks for contributing!
|
@ptomato Thank you for your review. I would like this PR to be merged as is. Maybe I'll send a PR to add test cases later. |
|
@sosukesuzuki Works for me. I'll merge this now and copy my comment into #4036 for whoever picks it up. |
ljharb
added a commit
to es-shims/Map.groupBy
that referenced
this pull request
Apr 4, 2024
ljharb
added a commit
to es-shims/Object.groupBy
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4036