Move testing of era/eraYear under intl402 #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
reviewed
May 3, 2022
...ilt-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-noniso.js
Show resolved
Hide resolved
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
May 4, 2022
I suggested in tc39#3517 that these lines should be removed but didn't realize they must be present because TemporalHelpers.assertPlainDateTime is going to check the 'era' and 'eraYear' properties.
Ms2ger
pushed a commit
that referenced
this pull request
May 5, 2022
I suggested in #3517 that these lines should be removed but didn't realize they must be present because TemporalHelpers.assertPlainDateTime is going to check the 'era' and 'eraYear' properties.
catamorphism
pushed a commit
to nicolo-ribaudo/test262
that referenced
this pull request
May 30, 2022
* Move testing of era/eraYear under intl402 * remove era/eraYear from built-in tests.
catamorphism
pushed a commit
to nicolo-ribaudo/test262
that referenced
this pull request
May 30, 2022
I suggested in tc39#3517 that these lines should be removed but didn't realize they must be present because TemporalHelpers.assertPlainDateTime is going to check the 'era' and 'eraYear' properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporal.PlainDateTime.prototype.ear and earYear are not defined in first 14 chapters and only defined under Chapter 15. Therefore they should always return undefined unless it is an intl implementation.
Copy the same test to intl402 and remove the non undefined value of era/eraYear from the built-ints version of test.
Fix #3516
Also see tc39/proposal-temporal#2169