Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl.DurationFormat update coverage #3501

Merged
merged 7 commits into from
May 3, 2022

Conversation

romulocintra
Copy link
Member

@romulocintra romulocintra commented Apr 25, 2022

Progressively adding a few more tests to Intl.Duration Format to improve ctor coverage

cc @sffc

#3305

@romulocintra romulocintra changed the title constructor tests coverage Intl.DurationFormat update coverage Apr 25, 2022
@romulocintra romulocintra marked this pull request as ready for review April 25, 2022 15:37
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ptomato
ptomato previously approved these changes May 2, 2022
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one optional improvement (up to you to decide) and one wording nitpick

Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
@ptomato ptomato merged commit 28455b1 into tc39:main May 3, 2022
catamorphism pushed a commit to nicolo-ribaudo/test262 that referenced this pull request May 30, 2022
* constructor tests coverage
* add localeMatcher tests
* add styles and numbering system tests
* re-organize folder and files structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants