You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Uses JamesIves/github-pages-deploy-action@4.1.4 to deploy output to the gh-pages branch under pr/<number>
Generates a preview URL using https://tc39.es/<repository>/pr/<number>
Uses phulsechinmay/rewritable-pr-comment@v0.3.0 to post a comment to the PR with a link to the generated preview:
By publishing to gh-pages you don't need to check in the docs folder (which can be safely added to .gitignore), which makes PR diffs easier to read.
NOTE: This does not currently do any kind of automatic pruning generated PR outputs, so that the links in a PR remain working. Pruning stale PR renders is a manual process that can be done by deleting PR-specific subfolders under the pr folder in the gh-pages branch using the GitHub UI.
The text was updated successfully, but these errors were encountered:
For PRs, I'm not sure about auto-deploying PRs to proposal repos, since proposal authors might not always be vigilant about keeping spam or inappropriate content out of them, and since closing a PR wouldn't automatically prune it. However, it seems like it'd be possible to add a workflow_run action that triggers on closed or merged PRs that auto-cleaned up the PR preview?
Either way, let's start with just the build.yml change for now, and we can iterate from there?
I'm not sure about auto-deploying PRs to proposal repos, since proposal authors might not always be vigilant about keeping spam or inappropriate content out of them
I noticed the proposal template repo has a
build.yml
github action. I recently wrote something similar for https://github.com/tc39/proposal-class-static-block that might be a useful improvement:JamesIves/github-pages-deploy-action@4.1.4
to deploy output to thegh-pages
branchpr/
folder from clean deploymentJamesIves/github-pages-deploy-action@4.1.4
to deploy output to thegh-pages
branch underpr/<number>
https://tc39.es/<repository>/pr/<number>
phulsechinmay/rewritable-pr-comment@v0.3.0
to post a comment to the PR with a link to the generated preview:By publishing to
gh-pages
you don't need to check in thedocs
folder (which can be safely added to.gitignore
), which makes PR diffs easier to read.NOTE: This does not currently do any kind of automatic pruning generated PR outputs, so that the links in a PR remain working. Pruning stale PR renders is a manual process that can be done by deleting PR-specific subfolders under the
pr
folder in thegh-pages
branch using the GitHub UI.The text was updated successfully, but these errors were encountered: