Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is blocking of pytest 7.0 needed? #761

Closed
Safihre opened this issue Feb 16, 2022 · 1 comment · Fixed by #771
Closed

Is blocking of pytest 7.0 needed? #761

Safihre opened this issue Feb 16, 2022 · 1 comment · Fixed by #771

Comments

@Safihre
Copy link

Safihre commented Feb 16, 2022

In your requirements.txt you block pytest 7.0 and fix it to 6.2.
Is that really needed? I saw in the 2.0 PR you still keep it fixed to 6.2.
I forcefully installed pytest 7.0 and the tavern-tests worked fine, at least in our project.

@michaelboulton
Copy link
Member

michaelboulton commented Feb 25, 2022

It's not required but I restricted it to <7 in case they changed the API, it looks like this is the only thing and should be easily fixed

#9488: If custom subclasses of nodes like pytest.Item override the init method, they should take **kwargs. See Constructors of custom pytest.Node subclasses should take **kwargs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants