Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(updater): use full path to msiexec #4738

Merged
merged 1 commit into from Jul 22, 2022
Merged

feat(updater): use full path to msiexec #4738

merged 1 commit into from Jul 22, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner July 22, 2022 14:25
@lucasfernog lucasfernog merged commit f116ee6 into dev Jul 22, 2022
@lucasfernog lucasfernog deleted the feat/msiexec-full-path branch July 22, 2022 14:59
@FabianLars
Copy link
Member

I don't think we can do this, while the default by a huge margin, there still is no guarantee that C is always the systemroot

@lucasfernog
Copy link
Member Author

You're right :( cc @amrbashir

lucasfernog added a commit that referenced this pull request Jul 22, 2022
@lucasfernog
Revert "feat(updater): use full path to msiexec (#4738)"
98e879f 
This reverts commit f116ee6.
@lucasfernog lucasfernog mentioned this pull request Jul 22, 2022
Merged
@amrbashir
Copy link
Member

amrbashir commented Jul 22, 2022 •
edited

yeah we need to to use %SystemRoot%\system32\msiexec.exe

%SystemRoot% is impossible to modify because it is set when Windows is installed.
More info can be found here https://renenyffenegger.ch/notes/Windows/dirs/Windows/index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasfernog @FabianLars @amrbashir