refactor(bundler): allow downgrades, add option to disallow on Windows #3777
Conversation
|
Sorry if I'm not up to speed on this one, but why do we need to change the default behavior? Making downgrades optional would also simplify the naming :) |
|
I feel most users would want to allow downgrades. And it's also the behavior on Linux and macOS too (AFAIK). |
|
as far as i am concerned it's because a) we allow downgrades on macos and linux and b) it's like the main "selling point" of the server variant of the updater. Edit: argh, too slow :)) |
|
hmmmm yeah that makes sense. What about the name though? |
|
I think "allow_downgrades" with default value of true is better naming. |
|
Changed it @amrbashir @JonasKruckenberg |
core/tauri-utils/src/config.rs
Outdated
| /// For instance, if `1.2.1` is installed, the user won't be able to install app version `1.2.0` or `1.1.5`. | ||
| /// | ||
| /// The default value of this flag is `true`. | ||
| #[serde(default)] |
There was a problem hiding this comment.
But isn't serde[default] for bools false?
There was a problem hiding this comment.
that's a problem with configuration flags that defaults to true :( way easier if it defaults to false
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information