fix(job): fetch parent before job moves to complete #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Dec 13, 2022
src/classes/job.ts
Outdated
| @@ -516,6 +516,11 @@ export class Job< | |||
| throw errorObject.value; | |||
| } | |||
|
|
|||
| const jobData = await Job.fromId(this.queue, this.id); | |||
There was a problem hiding this comment.
better to handle this logic atomically in moveToFinished script, so probably we may need to get parent values from there instead of providing it in args
There was a problem hiding this comment.
Added the fetch of the parent and the parentKey into the lua scripts.
|
Can we rerun the tests? On my local machine they went through |
manast
requested changes
Dec 15, 2022
manast
approved these changes
Dec 15, 2022
|
Any updates here @roggervalf? |
roggervalf
approved these changes
Dec 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [3.5.0](v3.4.2...v3.5.0) (2022-12-20) ### Bug Fixes * **job:** fetch parent before job moves to complete ([#1580](#1580)) ([6a6c0dc](6a6c0dc)) * **sandbox:** throw error when no exported function ([#1588](#1588)) fixes [#1587](#1587) ([c031891](c031891)) ### Features * **queue:** add getJobState method ([#1593](#1593)) ref [#1532](#1532) ([b741e84](b741e84))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a flow with a long-running job in the beginning (e.g. takes multiple seconds) and during the processing of the job you want to add a new parent to this job (because it should run after the long-running job) it doesn't execute the job which was added after.
The root cause of this issue is, that the worker fetches the
Jobfrom redis before it moves it to active. When theJobthen finishes, the worker passes the previous fetched instance of the job tomoveToCompleted. When an additional Job is added asparentof the current processing job, it never gets executed because the instance doesn't have the correct parent key.This PR adds an additional "sync" of the parent key of the job before it gets moved to completed to have the current instance up to date when in the meantime a new parent was added.
Added a test which runs the following flow: