Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'pluggy' to manage extension points #492

Open
ahal opened this issue Apr 23, 2024 · 0 comments
Open

Use 'pluggy' to manage extension points #492

ahal opened this issue Apr 23, 2024 · 0 comments
Labels
BREAKING CHANGE Backwards incompatible request that will require major version bump

Comments

@ahal
Copy link
Collaborator

ahal commented Apr 23, 2024

Currently we use an adhoc mish-mash of "register" functions and monkeypatching in order to extend Taskgraph. These places are not well documented and tend to be implemented inconsistently.

Pluggy is the extension manager used by Pytest and several other prominent projects. It would allow Taskgraph to expose well defined hook points that "plugins" can then call.

This would give extensions (like mozilla_taskgraph or project specific Taskgraph modules) well defined places to insert things into Taskgraph. We could then get rid of all the hacky monkeypatching and random importing of modules to trigger decorators.

@ahal ahal added the BREAKING CHANGE Backwards incompatible request that will require major version bump label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Backwards incompatible request that will require major version bump
Projects
None yet
Development

No branches or pull requests

1 participant