You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Taskgraph has worker-implementation-specific payload builders to convert abstract job definitions into taskcluster tasks. Payload builders declare a schema for the job properties they support. Jobs designed for Docker Worker contain properties that are currently not allowed by the Generic Worker payload builder, such as docker-image, allow-ptrace etc.
The d2g tool demonstrates that it is possible to transform a Docker Worker task definition into an equivalent Generic Worker task definition, and soon Generic Worker will perform this translation internally when running Docker Worker task payloads. However, task definitions designed for Docker Worker will not be able to use features that exist in Generic Worker only. Therefore it would be beneficial for the Generic Worker payload builder to support Docker Worker job definitions natively, and directly generate Generic Worker payloads that do not need to run through d2g inside of Generic Worker.
The d2g source code and command line utility can be used as a reference for understanding how to support Docker Worker features under Generic Worker. Furthermore, to validate that the updated payload builder works as anticipated, tests can be written that generate Docker Worker payloads from job definitions, transform them to Generic Worker using d2g, and compare the results to the same input job processed directly with the Generic Worker payload builder. The two should ideally be identical.
Note, the advantage of doing this, rather than having a transform step that runs d2g after generating a Docker Worker payload, is that eventually we can remove the Docker Worker payload builder altogether, and reduce the code footprint and complexity of dealing with multiple payload formats.
The text was updated successfully, but these errors were encountered:
Taskgraph has worker-implementation-specific payload builders to convert abstract job definitions into taskcluster tasks. Payload builders declare a schema for the job properties they support. Jobs designed for Docker Worker contain properties that are currently not allowed by the Generic Worker payload builder, such as
docker-image
,allow-ptrace
etc.The d2g tool demonstrates that it is possible to transform a Docker Worker task definition into an equivalent Generic Worker task definition, and soon Generic Worker will perform this translation internally when running Docker Worker task payloads. However, task definitions designed for Docker Worker will not be able to use features that exist in Generic Worker only. Therefore it would be beneficial for the Generic Worker payload builder to support Docker Worker job definitions natively, and directly generate Generic Worker payloads that do not need to run through d2g inside of Generic Worker.
The d2g source code and command line utility can be used as a reference for understanding how to support Docker Worker features under Generic Worker. Furthermore, to validate that the updated payload builder works as anticipated, tests can be written that generate Docker Worker payloads from job definitions, transform them to Generic Worker using d2g, and compare the results to the same input job processed directly with the Generic Worker payload builder. The two should ideally be identical.
Note, the advantage of doing this, rather than having a transform step that runs d2g after generating a Docker Worker payload, is that eventually we can remove the Docker Worker payload builder altogether, and reduce the code footprint and complexity of dealing with multiple payload formats.
The text was updated successfully, but these errors were encountered: