Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically choose taskcluster proxy port in generic worker #6953

Open
bhearsum opened this issue Apr 4, 2024 · 2 comments
Open

automatically choose taskcluster proxy port in generic worker #6953

bhearsum opened this issue Apr 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bhearsum
Copy link
Contributor

bhearsum commented Apr 4, 2024

At the moment, the taskcluster proxy port must be specified in the generic worker configuration. As far as I can tell, there's nothing external to generic worker that needs to know this port, which means it could potentially probe for a bindable port itself instead. This would help avoid misconfigurations like we found in https://bugzilla.mozilla.org/show_bug.cgi?id=1889647.

@bhearsum bhearsum added the bug Something isn't working label Apr 4, 2024
@petemoore
Copy link
Member

This is a nice idea. One thing to be careful of is that some tasks historically used http://taskcluster as the taskcluster proxy base URL. On workers, taskcluster name mapped to 127.0.0.1, typically via an entry in /etc/hosts or equivalent file on Windows. For backward compatibility, TASKCLUSTER_PROXY_URL is currently typically http://localhost:80 so that any tasks still using http://taskcluster for taskcluster proxy base URL still work. If we change default from being port 80, to being a non-static bindable port, anything using http://taskcluster explicitly will break. This is probably ok, most tasks by now should be using TASKCLUSTER_PROXY_URL env variable. But we should probably release this as a breaking change.

@petemoore petemoore added enhancement New feature or request and removed bug Something isn't working labels Apr 4, 2024
@petemoore
Copy link
Member

@jcristau also pointed out, workers could steal ports that tasks wanted to use, but perhaps that is acceptable fallout and can be worked around. I assume the request here is only to change default behavior when no port is specified. Presumably, the config property can be retained, so that an explicit value can be set to overwrite the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants