Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable several skipped tests in client library because of nock and node 20.10 issues #6923

Open
lotas opened this issue Mar 21, 2024 · 0 comments
Open

Enable several skipped tests in client library because of nock and node 20.10 issues #6923

lotas opened this issue Mar 21, 2024 · 0 comments

Comments

@lotas
Copy link
Contributor

lotas commented Mar 21, 2024

During upgrade to node 20 it was discovered that nock has some issues with mocking endpoints, this is why three tests were disabled: https://github.com/taskcluster/taskcluster/pull/6878/files#diff-ed1d5ac9fc5bdf958ee722903df5e16bc53f25bcd1764c8b466545ec5b8390faR290

After this issue gets fixed, we can upgrade and check if the issue is gone nock/nock#2595

We tested all minor versions of 20 release and discovered that issue first appeared in 20.10
mifi added a commit to transloadit/uppy that referenced this issue Apr 14, 2024
@mifi
fix node versions
9a66c5f 
because nock/nock#2595
the issue seems to have been introduced in node.js 20.10
taskcluster/taskcluster#6923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lotas