Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Worker Runner #6228

Open
petemoore opened this issue May 15, 2023 · 2 comments · May be fixed by #6229
Open

Remove Worker Runner #6228

petemoore opened this issue May 15, 2023 · 2 comments · May be fixed by #6229

Comments

@petemoore
Copy link
Member

Worker Runner was created for having common communication between workers and Worker Manager across worker implementations. Now that Docker Worker is being discontinued, there is no strong reason to continue supporting Worker Runner.

Furthermore, this should simplify communication between components, reduce complexity of deployment (fewer components to install, understand and configure) and reduce bugs due to inconsistent state between Worker Manager, Worker Runner and Generic Worker.
@petemoore petemoore linked a pull request May 15, 2023 that will close this issue
Draft
@aerickson
Copy link
Contributor

I think this will break how we use simple g-w and start-worker (gcp provisioner) to do Virtualbox VMs (for Wayland). We need to control launching of g-w (we launch g-w inside the virtualbox container vs locally) after start-worker has done the generation of the config.

@petemoore
Copy link
Member Author

That shouldn't be a problem. We can discuss at our next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove worker runner taskcluster/taskcluster
2 participants
@aerickson @petemoore