Skip to content

Errors from Azure API include the whole request, don't parse as JSON #4807

Closed
@djmitche

Description

@djmitche
Collaborator

I spent a bunch of time looking for errors from the Azure API, and eventually found them by removing all filters in StackDriver. They were huge blobs of JSON text that StackDriver wouldn't parse as JSON (because they were too long). This appears to be mostly because they include the entire request object in the error body.

It'd be great to fix this in some systematic way -- I can imagine lots of other errors are also too huge to get registered.

Activity

djmitche

djmitche commented on Apr 21, 2021

@djmitche
CollaboratorAuthor

STR:

  • set up an azure worker-manager provider, but don't give the app registration any permissions
  • create a worker in a pool using that provider
self-assigned this
on May 7, 2021
djmitche

djmitche commented on May 7, 2021

@djmitche
CollaboratorAuthor

I'm thinking of just iteratively removing the largest subkey of Fields until the message fits, but I'm not sure what the maximum line length is.

djmitche

djmitche commented on May 7, 2021

@djmitche
CollaboratorAuthor
djmitche

djmitche commented on May 7, 2021

@djmitche
CollaboratorAuthor

I ended up stripping any non-scalar values from error objects. That should get this pretty comprehensively, with minimal collateral damage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @djmitche

    Issue actions

      Errors from Azure API include the whole request, don't parse as JSON · Issue #4807 · taskcluster/taskcluster