Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-shell: Support completions for other shells #4534

Closed
ahal opened this issue Mar 11, 2021 · 1 comment · Fixed by #5670
Closed

client-shell: Support completions for other shells #4534

ahal opened this issue Mar 11, 2021 · 1 comment · Fixed by #5670
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ahal
Copy link
Contributor

ahal commented Mar 11, 2021

It looks like cobra supports command completions for bash, zsh, fish and PowerShell out of the box:
https://github.com/spf13/cobra/blob/master/shell_completions.md

But taskcluster-cli completions only supports bash. Would be awesome if we could hook up cobra's default completion command here instead.
@ahal ahal added the bug Something isn't working label Mar 11, 2021
@ahal ahal changed the title client_shell: Support completions for other shells client-shell: Support completions for other shells Mar 11, 2021
@djmitche djmitche added the good first issue Good for newcomers label Mar 15, 2021
@samihda samihda mentioned this issue Sep 11, 2022
Merged
@samihda
Copy link
Contributor

samihda commented Sep 12, 2022

@djmitche I created a PR to address this, please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add completions for other shells samihda/taskcluster
3 participants
@djmitche @ahal @samihda