Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth tests do not run without secrets #3503

Closed
djmitche opened this issue Sep 14, 2020 · 0 comments · Fixed by #3516
Closed

auth tests do not run without secrets #3503

djmitche opened this issue Sep 14, 2020 · 0 comments · Fixed by #3516
Assignees

Comments

@djmitche
Copy link
Collaborator

  22) services/auth/test/stories_test.js (real)                                                
       "before all" hook in "services/auth/test/stories_test.js (real)":
                                                                                               
      AssertionError [ERR_ASSERTION]: no value found for secret accountId                      
      + expected - actual                                                
                                                                                               
      -false                                                                                   
      +true                   
                 
      at /home/dustin/p/taskcluster/libraries/testing/src/secrets.js:110:7
      at Array.forEach (<anonymous>)                                      
      at Secrets.get (/home/dustin/p/taskcluster/libraries/testing/src/secrets.js:109:13)
      at Context.<anonymous> (test/helper.js:70:33)                                      

Per best practices, it should be skipping when those creds don't exist, except when NO_TEST_SKIP is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant