Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 164 causes hang when autoreset=True #196

Closed
bbayles opened this issue Oct 13, 2018 · 3 comments
Closed

PR 164 causes hang when autoreset=True #196

bbayles opened this issue Oct 13, 2018 · 3 comments

Comments

@bbayles
Copy link

bbayles commented Oct 13, 2018

Updating to 0.4.0 caused an application I work on to stop working. Investigating, I found that getting rid of autoreset=True fixed the hanging problem, but I need the autoreset behavior.

Working through the changes since 0.3.9, I found that reverting a3eabd2 fixes the problem. This the merge for PR #164.

I've not nailed down why this affects me - I'm not using PyCharm - but I expect you'll hear from others as this update proliferates. If I can pin it down I'll submit a PR.
@bbayles
Copy link
Author

bbayles commented Oct 13, 2018

Update: more specifically, it's 2057f03 that causes the hang. Keeping the PyCharm behavior from 3579cde seems fine; it's the moving of the function to a method that causes the problem.

This was referenced Oct 13, 2018
Closed
Merged
@Delgan Delgan mentioned this issue Oct 29, 2018
Open
wiggin15 pushed a commit that referenced this issue Nov 3, 2018
Merge pull request #198 from Delgan/fix_196
90f2fac 
Prevent exponential number of calls while accessing "closed" / "isatty" (#196)
@wiggin15
Copy link
Collaborator

Fixed in #198.

@wiggin15
Copy link
Collaborator

Uploaded v0.4.1 to PyPI. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wiggin15 @bbayles