Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add first implementation of the "on_pre_bake" hook #328

Closed
wants to merge 4 commits into from
Closed

[WIP] Add first implementation of the "on_pre_bake" hook #328

wants to merge 4 commits into from

Conversation

abusi
Copy link
Contributor

@abusi abusi commented Nov 6, 2019 •
edited

  • Code
  • Tests
  • Doc
  • Changelog

fixes #319

@abusi abusi added the WIP Work in progress label Nov 6, 2019
@abusi abusi added this to the V1.2 milestone Nov 6, 2019
@abusi abusi self-assigned this Nov 6, 2019
tsunammis
tsunammis reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@tsunammis tsunammis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abusi Could you add some tests to see the API?

tartiflette/schema/schema.py
custom_default_type_resolver: Optional[Callable] = None,
) -> None:
"""
Bake the final schema (it should not change after this) used for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abusi I'm wondering if it MUST not change after this stage? (the schema)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, because if the schema changes, it needs to be re-baked. But don't worry, this don't work yet It's really really early work.

@abusi
Copy link
Contributor Author

abusi commented Feb 20, 2020

This implementation was a bad idea, i'm starting over.

@abusi abusi closed this Feb 20, 2020
@abusi abusi deleted the bubu/on_bake branch February 20, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunammis tsunammis tsunammis left review comments

@Maximilien-R Maximilien-R Awaiting requested review from Maximilien-R

Assignees

@abusi abusi

Labels
WIP Work in progress
Projects
None yet
Milestone
V1.2
Development

Successfully merging this pull request may close these issues.

Support Hook schema bake hook for plugin
2 participants
@abusi @tsunammis