Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dalek fork to use newer versions #5575

Closed
hansieodendaal opened this issue Jul 5, 2023 · 5 comments
Closed

Upgrade dalek fork to use newer versions #5575

hansieodendaal opened this issue Jul 5, 2023 · 5 comments

Comments

@hansieodendaal
Copy link
Contributor

Rand core - 0.6
rand - 0.8
Digest 0.10
sha2 - 0.10

@hansieodendaal
Copy link
Contributor Author

@AaronFeickert
Copy link
Collaborator

A newer PR indicates the update is still pending upstream verification. What needs to be checked exactly?

@hansieodendaal
Copy link
Contributor Author

The actual requirement is to make https://github.com/tari-project/ledger work with curve25519-dalek and tari_crypto. It currently works when using curve25519-dalek pre-release candidate "4.0.0-rc.1". After some discussion, we agreed to use curve25519-dalek pre-release candidate "4.0.0-rc.3" as our base version, apply our specific changes on top and upgrade tari_crypto to follow suit.

@AaronFeickert
Copy link
Collaborator

AaronFeickert commented Jul 6, 2023

Got it. The partial precomputation functionality in the curve library fork is now an upstream PR, but it's unclear if/when it would be merged, especially since it looks like they're very close to a major version release. Fortunately, it was straightforward to apply the changes, so maintaining them on the fork shouldn't be much work. (Almost all of the changes are for documentation and tests.)

@SWvheerden
Copy link
Collaborator

is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants