feat: Add MatterMost remote #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a basic mattermost remote to handle recieving webhook events and posting messages with the API.
JamesMConroy
requested review from
delta592,
wass3rw3rk,
sjqnn and
JordanSussman
as code owners
|
thanks for the PR and apologies for the delay, i will give it a look in the coming days. also, looking to test it on a real or fake mattermost instance |
|
No worries @wass3rw3rk stuff happens and I've had PRs sit idle for longer. This did work with that local mattermost development container, but it didn't work with my company's MatterMost. We use the version packaged with Gitlab Omnibus and it's a pain to test against because it is in a sandbox environment. I don't know if it is our configuration or an issue with how I'm using the websocket library, but I would get a panic when trying to connect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a basic mattermost remote to handle receiving webhook events and posting messages with the API.
Should resolve #97
Types of changes
What types of changes is this pull request introducing to flottbot? Put an
xin the boxes that applyChecklist
You can fill this out after creating your PR. Put an
xin the boxes that applyTesting
To test I used the docker image and add user script from the MM bot example repo https://github.com/mattermost-community/mattermost-bot-sample-golang