Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename args prop to expose_args #24

Open
JordanSussman opened this issue Aug 31, 2018 · 0 comments
Open

Rename args prop to expose_args #24

JordanSussman opened this issue Aug 31, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers in progress
Projects
Milestone

Comments

@JordanSussman
Copy link
Collaborator

name: test
match: command
args:
  - var1

to

name: test
match: command
expose_args:
  - var1

This is consistent with expose_json_fields. So, any time we expose variable from within rules we would use the expose_ prefix.

@JordanSussman JordanSussman added enhancement New feature or request good first issue Good for newcomers labels Aug 31, 2018
@wass3r wass3r added the to do label Oct 8, 2018
@wass3r wass3r added this to the Refactor milestone Oct 8, 2018
@wass3r wass3r added in progress and removed to do labels Oct 10, 2018
@wass3r wass3r added this to To do in todo Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in progress
Projects
Status: To do
todo
  
To do
Development

No branches or pull requests

2 participants