Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case --force option is set, continue running tests even if one or more are hung #357

Open
Serpentian opened this issue Nov 2, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Serpentian
Copy link

test-run --help says that --force option makes the program to "go on with other tests in case of an individual test failure". Currently, if any test hangs, test-run just exits after sending SIGKILL to workers. From the developer prospective of view hanging and failing are the same: something doesn't work. When setting flag, I want to know how many and which tests doesn't work. We're not supposed to stop after hang.

Expected behavior: continue running.

@Serpentian Serpentian added bug Something isn't working teamX labels Nov 2, 2022
@Totktonada
Copy link
Member

Currently, if any test hangs, test-run just exits after sending SIGKILL to workers.

There is a test timeout (--test-timeout, 110 seconds by default) and it should gracefully handle a hung test. Hitting --no-output-timeout (120 seconds by default), where test-run SIGKILLs workers and exits, shouldn't occur normally.

It is possible to handle the no-output timeout gracefully as well. But we anyway need a reproducer for the situation, when you reach the no-output timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants