Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the script body parameter into test_run:create_server() #305

Open
Totktonada opened this issue May 26, 2021 · 0 comments
Open

Add the script body parameter into test_run:create_server() #305

Totktonada opened this issue May 26, 2021 · 0 comments
Labels
feature A new functionality
Milestone

Comments

@Totktonada
Copy link
Member

Example:

test_run:create_server(<name>, {
    <..other options are here..>
    script = [[
        box.cfg{
            listen = os.getenv('LISTEN'),
        }
        require('console').listen(os.getenv('ADMIN'))
    ]],
})
test_run:start_server(<name>, {<startup options>})

It is easier to have everything within a test file rather than spread across different files.

NB: There is no test_run:create_server(<...>) function yet, only test_run:cmd('create server <...>'). We should add the wrapper function to properly escape the script body. And, so, start_server(), restart_server(), stop_server(), cleanup_server(), delete_server() as well.

The idea was described first in #173 (comment).


There are thoughts around a way we want to use to start instances. Now we use tarantoolctl, iproto and console ports assigned by test-run. However, maybe, it would be more obvious to run 'pure tarantool' scripts. I don't know, to be honest.

@Totktonada Totktonada added the feature A new functionality label May 26, 2021
@kyukhin kyukhin added the teamQ label Sep 17, 2021
@kyukhin kyukhin added this to the wishlist milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

No branches or pull requests

3 participants