Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for multiple fastfield codecs #1063

Merged
merged 3 commits into from
May 31, 2021

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented May 27, 2021

prepare for multiple fastfield codecs by wrapping the codecs in an enum #1042

 prepare for multiple fastfield codecs by wrapping the codecs in an enum quickwit-oss#1042
@PSeitz PSeitz requested a review from fulmicoton May 27, 2021 17:18
add FastFieldSerializer trait
add DynamicFastFieldSerializer enum to wrap all implementors of the FastFieldSerializer trait
/// fastfields on disk.
///
/// Fast fields are encoded using bit-packing.
/// Fast fields have differnt encodings like bit-packing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you just fix the typo please?

@fulmicoton
Copy link
Collaborator

well merging. the typo is not that bad and can be fixed later.

@fulmicoton fulmicoton merged commit dff0ffd into quickwit-oss:main May 31, 2021
This was referenced Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants