add iterator over documents in docstore #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profiling, I saw that around 8% of the time in a merge was spent in look-ups into the skip index. Since the documents in the merge case are read continuously, we can replace the random access with an iterator over the documents. Merge Time on Sorted Index Before/After: 24s / 19s Merge Time on Unsorted Index Before/After: 15s / 13,5s So we can expect 10-20% faster merges. This iterator is also important if we add sorting based on a field in the documents.
fulmicoton
reviewed
May 18, 2021
| let store_reader = &store_readers[reader_with_ordinal.ordinal as usize]; | ||
| let raw_doc = store_reader.get_raw(*old_doc_id)?; | ||
| let store_reader = &mut document_iterators[reader_with_ordinal.ordinal as usize]; | ||
| let raw_doc = store_reader.next().expect(&format!( |
There was a problem hiding this comment.
can we return an error here? (the error message is great.)
|
a) this is great. |
fulmicoton
reviewed
May 18, 2021
src/store/reader.rs
Outdated
| /// Iterator over all RawDocuments in their order as they are stored in the doc store. | ||
| /// Use this, if you want to extract all Documents from the doc store. | ||
| /// The delete_bitset has to be forwarded from the `SegmentReader` or the results maybe wrong. | ||
| pub fn iter_raw<'a: 'b, 'b>( |
There was a problem hiding this comment.
this should probably be pub(crate)?
fulmicoton
reviewed
May 18, 2021
| let mut num_skipped = 0; | ||
| (0..last_docid) | ||
| .filter_map(move |doc_id| { | ||
| // filter_map is only used to resolve lifetime issues between the two closures on |
There was a problem hiding this comment.
I am incapable of reading this :)
But I think this is ok considering it has no adherence outside of this function
This was referenced Feb 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling, I saw that around 8% of the time in a merge was spent in look-ups into the skip index. Since the documents in the merge case are read continuously, we can replace the random access with an iterator over the documents.
Merge Time on Sorted Index Before/After:
24s / 19s
Merge Time on Unsorted Index Before/After:
15s / 13,5s
So we can expect 10-20% faster merges.
This iterator is also important if we add sorting based on a field in the documents.