Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow implicit returns #4640

Merged
merged 1 commit into from Dec 14, 2022

Conversation

kalseefer
Copy link
Contributor

close /issues/4607

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2126e4a:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@kalseefer kalseefer marked this pull request as ready for review December 14, 2022 17:09
@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.30% // Decreases project coverage by -4.05% ⚠️

Coverage data is based on head (f4d110d) compared to base (eab6e2c).
Patch has no changes to coverable lines.

❗ Current head f4d110d differs from pull request most recent head 66fd024. Consider uploading reports for the commit 66fd024 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4640      +/-   ##
==========================================
- Coverage   96.36%   92.30%   -4.06%     
==========================================
  Files          45       89      +44     
  Lines        2281     3758    +1477     
  Branches      640      992     +352     
==========================================
+ Hits         2198     3469    +1271     
- Misses         80      273     +193     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/react/utils.ts
src/react/tests/utils.tsx
src/core/mutationCache.ts
src/devtools/devtools.tsx
src/react/useBaseQuery.ts
src/devtools/tests/utils.tsx
src/core/hydration.ts
src/devtools/theme.tsx
src/devtools/useLocalStorage.ts
src/core/queryClient.ts
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit b82f05e into TanStack:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS7030: Not all code paths return a value.
3 participants