Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-async-storage-persister): support wider range of types #4639

Merged
merged 2 commits into from Dec 14, 2022

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Dec 14, 2022

interfaces like localforage return a Promise from setItem; we don't really care, as long as it's a Promise

interfaces like localforage return a Promise<T> from setItem; we don't really care, as long as it's a Promise
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 154e601:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

set a staleTime so that we don't get an additional fetch after the component re-mounts
@TkDodo TkDodo merged commit ce1259c into main Dec 14, 2022
@TkDodo TkDodo deleted the feature/support-localforage branch December 14, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant