Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): support rule prefer-object-syntax with multi lines #4637

Merged

Conversation

Newbie012
Copy link
Collaborator

fixes #4630

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bfde964:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@Newbie012 Newbie012 force-pushed the fix-prefer-query-object-syntax-multiline branch from 2f4e0c0 to 594217e Compare December 14, 2022 00:25
@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.36% // Decreases project coverage by -3.99% ⚠️

Coverage data is based on head (2f4e0c0) compared to base (eab6e2c).
Patch has no changes to coverable lines.

❗ Current head 2f4e0c0 differs from pull request most recent head 594217e. Consider uploading reports for the commit 594217e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4637      +/-   ##
==========================================
- Coverage   96.36%   92.36%   -4.00%     
==========================================
  Files          45       89      +44     
  Lines        2281     3748    +1467     
  Branches      640      992     +352     
==========================================
+ Hits         2198     3462    +1264     
- Misses         80      270     +190     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/devtools/tests/utils.tsx
src/react/setBatchUpdatesFn.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/core/hydration.ts
src/react/utils.ts
src/react/useInfiniteQuery.ts
src/react/useBaseQuery.ts
src/react/useMutation.ts
src/core/queriesObserver.ts
src/core/logger.ts
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Newbie012 Newbie012 force-pushed the fix-prefer-query-object-syntax-multiline branch from c86f6a1 to bfde964 Compare December 14, 2022 00:28
@TkDodo TkDodo merged commit d261823 into TanStack:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint: wrong autofix for multi-line queries
3 participants