Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-query): use distributive omit to preserve union #4562

Merged
merged 1 commit into from Nov 28, 2022

Conversation

henribru
Copy link
Contributor

Fixes #4556

Not sure if the tests are okay. I tried to base them on the type tests in the react-query package

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 029131c:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.34% // Decreases project coverage by -4.01% ⚠️

Coverage data is based on head (029131c) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4562      +/-   ##
==========================================
- Coverage   96.36%   92.34%   -4.02%     
==========================================
  Files          45       89      +44     
  Lines        2281     3751    +1470     
  Branches      640      991     +351     
==========================================
+ Hits         2198     3464    +1266     
- Misses         80      271     +191     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/core/mutation.ts
src/devtools/devtools.tsx
src/core/infiniteQueryObserver.ts
src/react/Hydrate.tsx
src/core/queryCache.ts
src/react/setBatchUpdatesFn.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/react/QueryErrorResetBoundary.tsx
src/react/logger.ts
src/devtools/useMediaQuery.ts
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@DamianOsipiuk DamianOsipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@DamianOsipiuk DamianOsipiuk merged commit f6d92a7 into TanStack:main Nov 28, 2022
efilion pushed a commit to efilion/query that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue reactive call no longer preserves union type of vue-query's useQuery
3 participants