Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add useQueries with suspense tests #4502

Merged
merged 3 commits into from Nov 13, 2022

Conversation

dante01yoon
Copy link
Contributor

@dante01yoon dante01yoon commented Nov 13, 2022

this is my first pr in query.

changes

added tests

  • shouldn't unmount before all promises fetched
  • should suspend all queries in parallel - global configuration

shouldn't unmount before all promises fetched
should suspend all queries in parallel - global configuration
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a483788:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.25% // Decreases project coverage by -4.10% ⚠️

Coverage data is based on head (a483788) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4502      +/-   ##
==========================================
- Coverage   96.36%   92.25%   -4.11%     
==========================================
  Files          45       89      +44     
  Lines        2281     3706    +1425     
  Branches      640      970     +330     
==========================================
+ Hits         2198     3419    +1221     
- Misses         80      271     +191     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/devtools/styledComponents.ts
src/devtools/tests/utils.tsx
src/react/Hydrate.tsx
src/core/subscribable.ts
src/core/focusManager.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/react/useQueries.ts
src/react/QueryErrorResetBoundary.tsx
src/core/logger.ts
src/react/setLogger.ts
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit f65e7af into TanStack:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants