Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): unset padding for resetting after closed #4477

Merged

Conversation

minami-minami
Copy link
Contributor

fixes #4467

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60ecf38:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration
billowing-architecture-is4kr2 Issue #4467

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 10, 2022

would it be possible to add a test for the new behaviour of restoring the old styles?

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.42% // Decreases project coverage by -3.93% ⚠️

Coverage data is based on head (da333f2) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
- Coverage   96.36%   92.42%   -3.94%     
==========================================
  Files          45       88      +43     
  Lines        2281     3577    +1296     
  Branches      640      923     +283     
==========================================
+ Hits         2198     3306    +1108     
- Misses         80      255     +175     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/devtools/theme.tsx
src/core/queriesObserver.ts
src/core/onlineManager.ts
src/react/setBatchUpdatesFn.ts
src/core/mutationCache.ts
src/react/reactBatchedUpdates.ts
src/devtools/tests/utils.tsx
src/react/useQueries.ts
src/react/useQuery.ts
src/react/useInfiniteQuery.ts
... and 123 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@minami-minami
Copy link
Contributor Author

@TkDodo
Added test 👍

@TkDodo TkDodo merged commit d5bf345 into TanStack:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After closed devtools, padding of parent element remains
3 participants