Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper rollup config for superjson #4263

Merged
merged 1 commit into from Oct 4, 2022

Conversation

DamianOsipiuk
Copy link
Contributor

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 49ff5fe:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 96.94% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (49ff5fe) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4263      +/-   ##
==========================================
+ Coverage   96.36%   96.94%   +0.58%     
==========================================
  Files          45       86      +41     
  Lines        2281     3273     +992     
  Branches      640      881     +241     
==========================================
+ Hits         2198     3173     +975     
- Misses         80       98      +18     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/react/useMutation.ts
src/core/retryer.ts
src/devtools/useLocalStorage.ts
src/devtools/devtools.tsx
src/core/query.ts
src/core/hydration.ts
src/core/infiniteQueryBehavior.ts
src/react/setLogger.ts
src/devtools/utils.ts
src/react/useInfiniteQuery.ts
... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I didn't know that we have to list all of these manually. maybe in the future, we can extract those dependencies from package.json ....

@TkDodo TkDodo merged commit 923c740 into TanStack:main Oct 4, 2022
@DamianOsipiuk
Copy link
Contributor Author

I think there are rollup plugins to auto-external deps from node_modules. But it was kind of finicky when i last tested it out.
Might give it another try to simplify this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants