Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: meta to Mutation #2906

Merged
merged 6 commits into from Nov 17, 2021
Merged

feat: meta to Mutation #2906

merged 6 commits into from Nov 17, 2021

Conversation

danielbartsch
Copy link
Contributor

the same meta that already exists in Query and is accessible in
queryCache is now also usable in mutationCache and can be passed in
useMutation, just as in useQuery

Context: TkDodo/blog-comments#29 (comment)

the same meta that already exists in Query and is accessible in
queryCache is now also usable in mutationCache and can be passed in
useMutation, just as in useQuery
@vercel
Copy link

vercel bot commented Nov 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/Y4AKnKDuFACteo5PhSeWuePB7N9d
✅ Preview: https://react-query-git-fork-danielbartsch-meta-to-usemutation-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b464b49:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #2906 (b464b49) into master (c118513) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2906   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          45       45           
  Lines        2226     2228    +2     
  Branches      636      637    +1     
=======================================
+ Hits         2146     2148    +2     
  Misses         77       77           
  Partials        3        3           
Impacted Files Coverage Δ
src/core/mutationCache.ts 100.00% <ø> (ø)
src/core/mutation.ts 100.00% <100.00%> (ø)
src/react/useBaseQuery.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c118513...b464b49. Read the comment docs.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good work, thank you 🚀

src/react/tests/useMutation.test.tsx Outdated Show resolved Hide resolved
src/core/mutation.ts Outdated Show resolved Hide resolved
Reason: #2906 (comment)

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally missed that we also need to update the documentation please

@danielbartsch
Copy link
Contributor Author

b464b49
I hope this is fine

@TkDodo TkDodo merged commit 5285479 into TanStack:master Nov 17, 2021
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants