Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use codepoints.json file #224

Open
miguelsolorio opened this issue Jun 11, 2021 · 2 comments · May be fixed by #225
Open

Unable to use codepoints.json file #224

miguelsolorio opened this issue Jun 11, 2021 · 2 comments · May be fixed by #225

Comments

@miguelsolorio
Copy link

miguelsolorio commented Jun 11, 2021

Trying to follow the instructions in this repo for setting up a codepoints.json file. The README says there are two options:

pathOptions: {
    json: './misc/icon-codepoints.json'
  },
  codepoints: {
    'chevron-left': 57344, // decimal representation of 0xe000
    'chevron-right': 57345,
    'thumbs-up': 57358,
    'thumbs-down': 57359
  },

When i reference codepoints directly (2nd option) the unicodes are correctly applied. But when used with the pathOptions (1st option) I am seeing the entire file ignore. What is the best way to reference and use a codepoints file?

Also, the README + cli helper would greatly benefit with more information as there's information in multiple areas and you have to hunt for the info by searching the repo + issues.

@miguelsolorio miguelsolorio linked a pull request Jun 11, 2021 that will close this issue
@mgibas
Copy link

mgibas commented Jul 15, 2021

pathOptions.json specifies where to save json file, not where to read it from.

@miguelsolorio
Copy link
Author

@mgibas it would be helpful if the README explained this otherwise everyone else is just guessing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants