Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Improve support for incremental/composite flags #337

Closed
tamj0rd2 opened this issue Jul 20, 2020 · 2 comments · Fixed by #353
Closed

Improve support for incremental/composite flags #337

tamj0rd2 opened this issue Jul 20, 2020 · 2 comments · Fixed by #353
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@tamj0rd2
Copy link
Owner

Summary

I have a project that makes use of tsc --build to build multiple projects using project references. Some of those referenced projects use the --incremental flag.

ncdc doesn't seem to benefit from the performance gains those tools give. e.g generating types can take 17 seconds to build even if there is a tsconfig.tsbuildinfo file.

Here's the API that should be able to help: microsoft/TypeScript#31432

Any changes need to keep backwards compatibility with non build/incremental typescript projects.
@tamj0rd2 tamj0rd2 added enhancement New feature or request help wanted Extra attention is needed labels Jul 20, 2020
@tamj0rd2
Copy link
Owner Author

tamj0rd2 commented Jul 21, 2020 •
edited

More help here: microsoft/TypeScript-wiki#225

https://github.com/TypeStrong/ts-loader/pull/935/files

tamj0rd2 added a commit that referenced this issue Jul 30, 2020
@tamj0rd2
feat(ts compilation): improve support for incremental and composite p…
4a3072e 
…rojects

If you are building a project that has project references, rather than having to rebuild and
typecheck your files, ncdc will make use of the tyepscript build API. It will build any files that
have not yet been built and then skip the additional typecheck.

fix #337
@tamj0rd2 tamj0rd2 mentioned this issue Jul 30, 2020
Merged
tamj0rd2 added a commit that referenced this issue Jul 30, 2020
@tamj0rd2
feat(ts compilation): improve support for incremental and composite p…
306f59e 
…rojects

If you are building a project that has project references, rather than having to rebuild and
typecheck your files, ncdc will make use of the tyepscript build API. It will build any files that
have not yet been built and then skip the additional typecheck.

fix #337
probot-auto-merge bot pushed a commit that referenced this issue Jul 30, 2020
@tamj0rd2 @probot-auto-merge
feat(ts compilation): improve support for incremental and composite p…
aac45a3 
…rojects

If you are building a project that has project references, rather than having to rebuild and
typecheck your files, ncdc will make use of the tyepscript build API. It will build any files that
have not yet been built and then skip the additional typecheck.

fix #337
tamj0rd2 pushed a commit that referenced this issue Jul 30, 2020
@semantic-release-bot
chore(release): 0.12.0 [skip ci]
47e0da8 
# [0.12.0](v0.11.0...v0.12.0) (2020-07-30)

### Features

* **ts compilation:** improve support for incremental and composite projects ([aac45a3](aac45a3)), closes [#337](#337)
@tamj0rd2
Copy link
Owner Author

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ts compilation): improve support for incremental and composite p… tamj0rd2/ncdc
1 participant
@tamj0rd2