Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check region epoch before updating the region approximate size #448

Open
niebayes opened this issue May 7, 2023 · 1 comment
Open

Check region epoch before updating the region approximate size #448

niebayes opened this issue May 7, 2023 · 1 comment

Comments

@niebayes
Copy link
Contributor

niebayes commented May 7, 2023

When a peer receives a MsgTypeRegionApproximateSize message from the split checker, it simply updates its cached ApproximateSize without any checking.
The region might be recently split when the peer receives this message. On this occasion, the update seems wrong.
I wonder if the checking for region epoch is necessary before the update.

@Connor1996
Copy link
Collaborator

As the messages of one peer are serialized in one channel, the MsgTypeRegionApproximateSize should be handled before split is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants