Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsist format of "key" in log #367

Open
oocococo opened this issue Jan 5, 2022 · 0 comments · May be fixed by #368
Open

inconsist format of "key" in log #367

oocococo opened this issue Jan 5, 2022 · 0 comments · May be fixed by #368

Comments

@oocococo
Copy link
Contributor

oocococo commented Jan 5, 2022

In the client side, we use fmt.Sprintf("%08d", j) this format to represent "key", which is actually some thing like 1 0000001
But when we log things, we use "%v" and hex.EncodeToString to print key

log use "%v" format will be like 01 40 32 42 42 53 12 31
log use hex.EncodeToString will be like 31313131312
only if we use "log.Infof( "%s“, key ) it will be like 1 0000001, which is easy to understand

The inconsist format of "key" is disturbing in logging.

@oocococo oocococo linked a pull request Jan 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant