Bug: 1.4.1 still does not support global configuration

[shaobeichen]

What did you do?

git cz works, but doesn't use global config.

What did you expect to happen?

czvinyl supports global configuration

What actually happened?

Participation

• I am willing to submit a pull request for this issue.

Additional comments

No response

[tal-rofe]

@shaobeichen
Could you please share what's the directory on which you store the files?
Also, does it work if you set .czrc file in the project directory level?
I tested it on MacOS and it worked.
I will check on Windows, depends on your answer

[shaobeichen]

C:\Users\xxxxxxx

[tal-rofe]

C:\Users\xxxxxxx

Will check.

[tal-rofe]

@shaobeichen

It may take a while as I only own a macOS machine. If you'd like to make a PR it will be great

[shaobeichen]

I modified the configuration file, from the log results, I think it is the problem of cosmiconfig, but I don't know how to solve it for the time being.

output

# console.log(SEARCH_PLACES)
[
  'package.json',   
  '.czvinylrc',     
  '.czvinylrc.json',
  '.czvinylrc.yaml',
  '.czvinylrc.yml', 
  '.czvinylrc.js',  
  '.czvinylrc.ts',  
  '.czvinylrc.cjs', 
  'czvinyl.config.js',
  'czvinyl.config.ts',
  'czvinyl.config.cjs',
  'C:\\Users\\D1M\\package.json',
  'C:\\Users\\D1M\\.czvinylrc',
  'C:\\Users\\D1M\\.czvinylrc.json',
  'C:\\Users\\D1M\\.czvinylrc.yaml',
  'C:\\Users\\D1M\\czvinyl.config.cjs'
]

# console.log(result, result1 && result1.filepath)
null, C:\Users\D1M\.czvinylrc

System Info
Output of npx envinfo --system --npmPackages vue --binaries --browsers

  System:
    OS: Windows 10 10.0.19043
    CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
    Memory: 6.88 GB / 15.88 GB
  Binaries:
    Node: 16.13.1 - D:\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD       
    npm: 8.1.2 - D:\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (104.0.1293.70)
    Internet Explorer: 11.0.19041.1566

[tal-rofe]

@shaobeichen

Regarding the 2nd log, What if you were to log the result itself (result1)? You'd get the configured file as you expect?

[shaobeichen]

@shaobeichen

Regarding the 2nd log, What if you were to log the result itself (result1)? You'd get the configured file as you expect?

Yes, result1 can get the file path and content I want, but search cannot; I tried to use mjs file to remove loaders, but the result of search is still null

[tal-rofe]

@shaobeichen
Did you try to replace SEARCH_PLACES with an hardcoded value? for example C:\Users\D1M\.czvinylrc. Would it work? Need to understand whether issue with cz-vinyl or with cosmiconfig

[shaobeichen]

yes, i tried the hardcoded way and it still doesn't work, I set it as below so it doesn't work

[
  'C:/Users/D1M/.czvinylrc',
]
[
  'C:\Users\D1M\.czvinylrc',
]
[
  'C:\\Users\\D1M\\.czvinylrc',
]
[
  'package.json',   
  '.czvinylrc',     
  '.czvinylrc.json',
  '.czvinylrc.yaml',
  '.czvinylrc.yml', 
  '.czvinylrc.js',  
  '.czvinylrc.ts',  
  '.czvinylrc.cjs', 
  'czvinyl.config.js',
  'czvinyl.config.ts',
  'czvinyl.config.cjs',
  'C:/Users/D1M/package.json',
  'C:/Users/D1M/.czvinylrc',
  'C:/Users/D1M/.czvinylrc.json',
  'C:/Users/D1M/.czvinylrc.yaml',
  'C:/Users/D1M/czvinyl.config.cjs'
]
[
  'package.json',   
  '.czvinylrc',     
  '.czvinylrc.json',
  '.czvinylrc.yaml',
  '.czvinylrc.yml', 
  '.czvinylrc.js',  
  '.czvinylrc.ts',  
  '.czvinylrc.cjs', 
  'czvinyl.config.js',
  'czvinyl.config.ts',
  'czvinyl.config.cjs',
  'C:\Users\D1M\package.json',
  'C:\Users\D1M\.czvinylrc',
  'C:\Users\D1M\.czvinylrc.json',
  'C:\Users\D1M\.czvinylrc.yaml',
  'C:\Users\D1M\czvinyl.config.cjs'
]
[
  'package.json',   
  '.czvinylrc',     
  '.czvinylrc.json',
  '.czvinylrc.yaml',
  '.czvinylrc.yml', 
  '.czvinylrc.js',  
  '.czvinylrc.ts',  
  '.czvinylrc.cjs', 
  'czvinyl.config.js',
  'czvinyl.config.ts',
  'czvinyl.config.cjs',
  'C:\\Users\\D1M\\package.json',
  'C:\\Users\\D1M\\.czvinylrc',
  'C:\\Users\\D1M\\.czvinylrc.json',
  'C:\\Users\\D1M\\.czvinylrc.yaml',
  'C:\\Users\\D1M\\czvinyl.config.cjs'
]

[tal-rofe]

@shaobeichen

Seems like the 3rd party library has an issue.

[13OnTheCode]

@tal-rofe

You are correct. I have conducted preliminary tests and it seems that the reason is because macOS has a unified directory structure with a single home directory serving as the user's personal file space. On the other hand, Windows uses a partition-based concept and follows a layered directory structure, organizing files and directories using logical disks such as C, D, E, etc., each having its own root directory. After briefly examining the source code of cosmiconfig, it appears that no additional handling for Windows systems has been implemented. It is unclear whether this was intentionally done by the developers or if it was overlooked

Testing process:

I executed cosmiconfig(...).search(...) inside D:\Developer\13OnTheCode\test\index.js As a result, cosmiconfig recursively reached the "home directory" on the D drive, rather than the C drive. Therefore, when the configuration file is created in the root directory of the D drive, it can be found successfully

I just discussed (Zhengqbbb/cz-git#132) this issue in cz-git and submitted a PR (Zhengqbbb/cz-git#133) because it also has the same problem that prevents Windows users from loading the global configuration correctly.

I hope this will be helpful for cz-vinyl

[shaobeichen]

It seems that v9 has been resolved，cosmiconfig/cosmiconfig#278

[tal-rofe]

It seems that v9 has been resolved，cosmiconfig/cosmiconfig#278

Once cosmiconfig will upgrade by Renovate to V9

[tal-rofe]

@shaobeichen
I just created a new release on both GitHub & NPM for version 2.5.0 which uses cosmiconfig@9 new major. Please test it with the new version and update, so we could finally close this issue.